[PATCH] Switch some columns to right alignment in divelist

Anton Lundin glance at acc.umu.se
Thu Sep 11 13:58:54 PDT 2014


On 03 September, 2014 - Davide DB wrote:

> Anton I see what you mean..

Please don't top post.

> Regarding the first point you are right. Numbers should be left aligned.

What? You mean Right aligned?

> Most of my dives are > 1h.

Mine to. Doesn't matter here, things should align right in the cases
where they might be shorter, 10h+ or whatever.

> Actually it's the same for depth. I have some three digit dives and it's wrong:
> 
> 100
> 52
> 
> Supposed we are using a monospaced font, it should be:
> 
> 100
>  52
> 
> Just remember that Column heading must always follow data alignment.
> 

Some trickery later, thats fixed. v2 coming up.

> Regarding the http://trac.hohndel.org/ticket/561 I opened three months
> ago. Look at my dive list with one trip before/after the patch. The
> dive #171 is not part of the trip but on windows and Mac had the same
> indentation. I hope this not break the fix.
> 

I would rather see all the dive numbers on the same visual alignment and
have some other sort of end-of-trip-marker, but i get the reason for
this.

So, a compromize might be to leave the NR-column left-aligned and move
the rest of our numeric columns to be right-aligned?

//Anton

-- 
Anton Lundin	+46702-161604


More information about the subsurface mailing list