[CCR PATCH] PO2 Calculations extracted to separate function.

[Willem Ferguson]

On 15/09/2014 16:05, Robert Helling wrote:
>
> On 15.09.2014, at 12:09, Robert Helling <helling at atdotde.de 
> <mailto:helling at atdotde.de>> wrote:
>
> Hi everybody,
>
>> To me, it would make much more sense to have a helper function that 
>> returns all three partial pressures given a gas mix and an ambient 
>> pressure (and a measured pO2 and possibly another variable indicating 
>> the type of dive i.e. OC, CCR or PSCR).
>>
>> BTW, code with a similar function (i.e. get partial pressures from an 
>> ambient pressure and gas mix) are also found in add_segemnt in 
>> deco.c. There, you also want to use your helper functions.
>>
>
> this patch demonstrates how I would do this.
>
> Best
> Robert
>
Robert,

I  have a tiny, tiny bit of the overall perspective that you have. My 
perspective has been purely focused on reading a XML log file and then 
putting together the plot_info structure for drawing the profile of a 
dive. Therefore I am ignorant of the places where such a helper function 
could hook in.

With respect to your proposal the only thing that I would change is to 
pass a pointer to a dc structure to your fill_pressures() function, and 
not only the dc-type.  That way the function has access to other 
important information specified in the dc structure such as the number 
of po2 sensors.

Would you consider at all to submit your proposal as a patch, then I can 
easily take it from there onwards?

Kind regards,
willem

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140915/b20093e1/attachment.html>