qmake support is going away

[Lubomir I. Ivanov]

On 17 April 2015 at 20:15, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Thu, Apr 16, 2015 at 07:58:10PM +0300, Lubomir I. Ivanov wrote:
>>
>> it's not really your faul Tomaz, it's Windows not being compatible
>> with *nix and the tools being worse. :-(
>>
>> attached is my cmake txt file.
>>
>> i've added and removed some options and hardcoded some
>> pkg_config_library() calls.
>>
>> the command line is:
>> cmake -G "MinGW Makefiles" -DCMAKE_BUILD_TYPE=Debug -DNO_DOCS=1
>> -DNO_MARBLE=1 -DNO_TESTS=1 ..
>>
>> i think for now i'm going to maintain the qmake setup for a bit longer
>> because it's more forgiving...or keep forking the cmake setup (which
>> is less preferred).
>
> I'd rather integrate what you need. I want to stop having different files.
> That's part of the reason for switching to cmake in the first place.
>
> So with the latest master, what still breaks for you?
>

two patches attached:
1) this adds some options - NO_TESTS, NO_DOCS etc.
please let me know if these don't make any sense.

the PKGCONFIG_* options allow me to use my library path where libgit
and libdc are installed even if forked from the subsurface git.

looks like the way to test if an options is ON is via:
IF(SOME_OPTION)
...

i'm able to build with the following cmd line:
cmake -G "MinGW Makefiles" -DCMAKE_BUILD_TYPE=Debug
-DPKGCONFIG_LIBGIT2=1 -DPKGCONFIG_LIBDC=1 -DNO_DOCS=1 -DNO_MARBLE=1
-DNO_TESTS=1 ..

2) whitespace cleanup
- real tabs
- indentation

-------

coding style wise:

the case insensitive format of cmake can be a bit confusing. i see
different projects use different style, but i suggest that we convert
all built-in macros to lower case e.g.:

OPTION() -> option()
IF() -> if()
ELSEIF() -> elseif()
SET() -> set()
etc...

lubomir
--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cmake-add-more-options.patch
Type: application/octet-stream
Size: 4100 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150417/de7bca58/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-cmake-whitespace-cleanup.patch
Type: application/octet-stream
Size: 6783 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150417/de7bca58/attachment-0001.obj>