Segfault on Windows daily build

[Lubomir I. Ivanov]

On 7 August 2015 at 02:38, Rick Walsh <rickmwalsh at gmail.com> wrote:
>
>
> On 7 August 2015 at 09:35, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
>>
>> On 7 August 2015 at 02:23, Rick Walsh <rickmwalsh at gmail.com> wrote:
>> >
>> >
>> > On 7 August 2015 at 08:35, Lubomir I. Ivanov <neolit123 at gmail.com>
>> > wrote:
>> >>
>> >> On 7 August 2015 at 00:40, Rick Walsh <rickmwalsh at gmail.com> wrote:
>> >> > Hi,
>> >> >
>> >> > I had to boot into Windows 8 on my laptop, so thought I might as well
>> >> > try
>> >> > the latest Subsurface daily on it
>> >> > (subsurface-4.4.2-1319-g3efafd1fde50).
>> >> >
>> >> > Upon opening the planner, I got a segfault.  I couldn't see any
>> >> > meaningful
>> >> > debug messages, and do not know how to run programs on Windows in
>> >> > debug
>> >> > mode.
>> >> >
>> >> > Sorry (not sorry) I'm about to head off for a few days of collecting
>> >> > dive
>> >> > computer data in some amazing limestone sinkholes, so can't help much
>> >> > trying
>> >> > to work out the cause of this.
>> >> >
>> >>
>> >> patch attached:
>> >> -------------
>> >>     Planner: use the heap for note buffers
>> >>
>> >>     The default stack size on Windows per thread is 1024kb.
>> >>     Using the heap prevents a stack overflow in add_plan_to_notes().
>> >>
>> >>     The alternative is to tell the linker to use N bytes of stack:
>> >>     -Wl,--stack,N
>> >> -------------
>> >>
>> >> the default size on Linux is probably 8172kb.
>> >
>> >
>> > Thanks for responding so quickly to what I thought would not be a
>> > helpful
>> > bug report.  I can't build for Windows, but I wanted to make sure it
>> > didn't
>> > break things on Linux.  Unfortunately, I cannot apply your patch to the
>> > latest master.
>> >
>>
>>
>> my bad,
>> this one should apply.
>
>
> And it does.  I can't test on Windows, but it doesn't break the planner
> notes on Linux.
>

amended version to remove possible memory leaks.

lubomir
--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Planner-use-the-heap-for-note-buffers.patch
Type: text/x-patch
Size: 17694 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150807/6ac60c80/attachment-0001.bin>