Customizable prints progress

Lubomir I. Ivanov neolit123 at gmail.com
Sun Aug 9 06:48:51 PDT 2015


hey, Gehad.

i'm getting some errors:
templatelayout.cpp:310:6: error: redefinition of 'void Dive::put_tags()'

same for:
::put_sac()
::put_gas()

removing the duplicates in the .cpp solves the issue.

i know these layout adjustments are annoying but we need to fix them
before the user feedback as more will stack and we may lose track of
what has to be done.

On 9 August 2015 at 04:10, Gehad Elrobey <gehadelrobey at gmail.com> wrote:
>
>
> On Thu, Aug 6, 2015 at 11:51 AM, Lubomir I. Ivanov <neolit123 at gmail.com>
>>
>> here are some observations and comments. even if i'm not a great
>> designer, i will try to provide you with some detailed feedback on
>> each template. basically i suggest that we solve these before pushing
>> to master and then we can start wrapping things up with community
>> feedback and eventual fixes before the GSoC "pencils down" date.
>>
>> 1) all colors themes:
>> i suggest we introduce another color so that we have "Table cells 1"
>> and "Table cells 2". "Table cells 2" will be what color we have at the
>> moment as "Background" and "Background" will be a default white
>> (0xffffff) for all templates and themes. my reasoning behind this is
>> that solid colors on the *whole* page don't make sense for everyone,
>> so some might want to use white, while the second color for the table
>> cells is nice to have.
>>
>> also please add a "Table border" color defaulting to black (0x000000)
>> on all templates.
>>
>
> Done.

please rename, "Table cells" to "Table cells 1".

>
>>
>> 2) generic changes for *all* templates:
>> - divide the current border width by two (if by two is too much try * 2/3)
>
>
> Actually there is a problem with sizing the borders in QWebView, I calculate
> the borders as follows:
>
> border-width: max(1px, 0.1vw);
>
> For some reasons the view width ratio "0.1vw" is not calculated, so the
> value assigned is always 1px border which appears to be thick in low
> resolution prints and small paper sizes, while it is so thin in high
> resolution/ large paper sizes (eg. A0).
>
> I don't know why "vw" sizing is not working as supposed with border-width in
> QWebView though it works correctly for me in Chromium & Firefox.

"vw" seems to be (used to be) buggy in most browsers.
but having no support for the table border width is quite bad. :\

what alternatives do we have? can we dynamically adjust the user value
in the templates based on the selected printer DPI or something?

>
>>
>> - remove the outer most border for all templates except "table". it
>> acts like a separator between dives, but we didn't have it in the

let's remove the outer border on "table" as well. it just doesn't look
right to have the border's top on the first page and the border's
bottom on the last page.

>> previous version
>> - make the actual data font width regular (not bold) - e.g. Dive No
>> (bold): 232 (not bold)
>> if it looks too small, increase the default font height to 10
>> (probably not needed).
>>
>
> Done.
>

the font change looks good.

>>
>> 2) flow layout:
>> - there is still some empty space (margin) on the right.
>
>
> Fixed.
>
>>
>> - the dive profile is missing - not sure how easy it is to add it?
>
>
> AFAIK there is no straight forward way to implement this, as the flow layout
> can break dives into pages and breaking the dive profile rendering into
> pages is not easy, I will put this at my todo list, I can look into it after
> the scoop of GSoC.

OK, understood. the idea behind the ideal flow layout would be to
support any length of notes while transitioning dives to new pages,
but also supporting the dive profiles is some way.

>
>>
>> - the end of last dive on the page is cut and the same applies to the
>> start of the next dive on the new page. is that related to the page
>> calculations or is it a CSS/HTML?
>>
>
> it was related to the incorrect page margins and fixed.
>

doesn't seem fixed for me. please, see flow.jpg.

>>
>> 3) one dive:
>> - there is still some empty space (margin) on the right.
>> - it doesn't look like the "one dive per page" in the previous
>> version, but apart from the generic changes we are going to leave it
>> as is, until user feedback

please, add more padding on the top of the profile so that the
left-right-top padding around the profile is the same.
see 1dive.jpg

>>
>> 4) six dives:
>> - thanks for adding this one
>> - there is still some empty space (margin) on the right.
>>

see 6dives.jpg.
there is white space on the top of the page and between the dives.


>> 5) table:
>> - there are margins on the top, left, right which are undefined. the
>> table should fit the page width and start from the top when no margins
>> are set.
>> - leave the outer border for this template, but reduce it's size as
>> mentioned in "generic"
>
>
> The borders issue is still existing, described above.
>

as mentioned, remove the outer border for this template as well. make
it so that that the inner borders use the color specified by "Border"
currently it seems that there are no borders around the table cells
and the "Background" color is visible there.

>>
>> - the "Table cells 1" color continues on the left and right of the
>> table, should stop where the outer border ends

ok, this is fixed.

>> - dives at the end of the pages are still cut, probably due to the
>> unwanted margins on top

i can't reproduce this anymore, but hopefully it won't break for a
different set of dives and different page dimensions.

>>
>> 6) two dives:
>> - there is still some empty space (margin) on the right.
>>

see 2dives.jpg
please add some more padding right from the profile.

at the bottom of this JPG can be seen some white space which is
present on *all* templates. can this be removed?
i think it could be a rounding error when you calculate the page height...

>
> I guess I fixed all the remaining issues, and pushed them to my branch,
> please check them and update me if I got any of them incorrectly. I also
> added a simple statistics view and some other bug fixes.

for the statistics type of print, i think we need use a new set of templates.
so, if the user selects "Statistics" the combo box in "Template" needs
to be re-filled with a different list.

perhaps a couple of folders in printing_templates need to be used for that:
"divelist"
"statistics"

in general, i'm not sure how the "Stats" print is going to work. if
it's only going to use one template then we need to disable the Import
/ Export and so on.
if it can support multiple templates then the combo box makes sense, i guess.

>
> Now I will work mainly on fixing the page scrolling bug and the
> documentation until you update me with further fixes/enhancements.
>

what is the "scrolling bug"?

lubomir
--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flow.jpg
Type: image/jpeg
Size: 62162 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150809/1ff98163/attachment-0004.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1dive.jpg
Type: image/jpeg
Size: 58341 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150809/1ff98163/attachment-0005.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 6dives.jpg
Type: image/jpeg
Size: 89768 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150809/1ff98163/attachment-0006.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2dives.jpg
Type: image/jpeg
Size: 69575 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150809/1ff98163/attachment-0007.jpg>


More information about the subsurface mailing list