[PATCH] Fix regular expressions for git repositories

Salvador Cuñat salvador.cunat at gmail.com
Mon Aug 10 11:42:55 PDT 2015


Hi guys.

2015-08-10 17:01 GMT+02:00 Miika Turkia <miika.turkia at gmail.com>:

> On Mon, Aug 10, 2015 at 10:01 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> > I'm reasonably certain that I tested the existing code and that it works
> -
> > I'm ok being proven wrong, but I'd like to make sure that this is at
> least
> > tested and not submitted as "I didn't test it but the original code
> looked
> > wrong" :-)
>
> What strikes me odd is that the first angle bracket ([) is escaped but
> the closing one (]) is not. The original code escaped them both
> (overwritten by commit 152eeb45d64db1398145ef7a935a132707b75e43), but
> the improved code lost the escaping from the closing angle bracket.
>
>
I've been testing this a bit and, curiously, both regexps worked fine.
Tested on local git repository from CLI and form GUI.  Couldn't test on
remote git as I couldn't achieve a conection with the server  (always
getting an error).

Regards

Salva.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150810/dae4d1a7/attachment.html>


More information about the subsurface mailing list