[PATH] Add native Bluetooth support for Windows platforms

[Dirk Hohndel]

On Fri, Aug 14, 2015 at 12:13:40AM +0300, Claudiu Olteanu wrote:
> These patches will add Bluetooth support for Windows platforms
> and will fix some potential issues.
> 
> Since we cannot use the QtBluetooth framework I needed to
> implement our custom Bluetooth device discovery agent.
> I decided to create a separated class and raise the same signals
> as QtBluetoothDeviceDiscoveryAgent class.
> 
> I am not sure if this is the best idea or the most elegant one but it works.

I have pushed the changes to the libdc/Subsurface-testing branch,
but I'd like to hear from Thiago before merging this into Subsurface...

> Subject: [PATCH 03/17] Use only the BTH address to check if the device was
>  already added
> 
> There are moments when the name of the device cannot be obtained.
> Therefore we should use only the Bluetooth address to identify if
> the discovered device was already added to the list.

Can you explain this a bit more? Should we not prefer the deviceLabel IF
we can get it?

For the rest of the patches...

a) I really like how you broke things down into reasonable commits, first
providing the placeholders and then implementing things one at a time.
That makes it much easier to digest what you did there.

b) did you write all this from scratch or was this inspired by some
existing BT code for Windows from some other project? This is a
non-trivial chunk of code in an area I'm not very familiar with...
(and just to avoid email communication issues - no, I'm not doubting that
you wrote this code... I just want to make sure that if there is a source
we should credit that we do).

Thanks

/D