Customizable prints progress

[Gehad Elrobey]

On Sat, Aug 15, 2015 at 2:23 PM, Lubomir I. Ivanov <neolit123 at gmail.com>
wrote:

> On 15 August 2015 at 14:59, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
> > On 14 August 2015 at 23:54, Gehad Elrobey <gehadelrobey at gmail.com>
> wrote:
> >>
> >>
> >> On Thu, Aug 13, 2015 at 10:47 AM, Lubomir I. Ivanov <
> neolit123 at gmail.com>
> >> wrote:
> >>>
> >>> On 12 August 2015 at 18:47, Gehad Elrobey <gehadelrobey at gmail.com>
> wrote:
> >>> > Hello Lubomir,
> >>> >
> >>> > I have resolved most of the issues you have mentioned above, still
> >>> > working
> >>> > on enhancing the statistics view, I hope I didn't miss anything so
> >>> > please
> >>> > have a look and update me if you have any notes.
> >>> > All commits are pushed to my branch.
> >>> >
> >>>
> >>> most of the templates look good, but there are still some issues.
> >>> also, i think we are missing the logic to tell the viewport where a
> >>> new HTML page starts. would JS be needed for that? let me know if you
> >>> need ideas about this one [1].
> >>>
> >>> let's enumerate the issues for better tracking:
> >>>
> >>> 1. all templates: the page calculation still leaves a couple of pixels
> >>> at the end of the page blank. i think you may have a slight rounding
> >>> error in the viewport code.
> >>> see 0.jpg
> >
> > re: "Printing: remove silly white line at end of each page"
> >
> > so this is a Qt < 5.3 issue and on such older versions the page page
> > calculation will be slightly off and the white pixels will appear - am
> > i right?
> > if so, can we adjust the calculation somehow for Qt < 5.3?
> >
> >>>
> >>> 2. table: the table is still cut on a new page. can we make it so that
> >>> the new page always starts at a new row [1]?
> >>> see 1.jpg
> >>>
> >>> 3. flow: cut on a new page [1]
> >>> see 2.jpg
> >>>
> >>> 4. flow: use the same background for all the data cells
> >>> see 3.jpg
> >>>
> >>> 5. one dive: use the same background for all the data cells
> >>> (similar to 4.)
> >>>
> >>> 6. six dives: the table is missing backgrounds and borders. please
> >>> style it the same as the tables in the other templates.
> >>> see 4.jpg
> >>>
> >>> 7. two dives: add more text padding on the left (margins)
> >>> see 5.jpg
> >>>
> >>> 8. two dives: reduce the width of the profile so that the padding on
> >>> the right of it is equal to the padding bottom from it.
> >>> see 5.jpg
> >>
> >>
> >>
> >> I have fixed the issues you have mentioned and I pushed the commits to
> my
> >> branch.
> >>
> >
> > ok, i have reviewed everything.
> >
>
> a small suggestion - in the future try limiting the number of
> characters in the commit message title and body to 80 (or less) as it
> can mess with some online or desktop viewing software.
>

I will take care of that.

-- 
regards,

Gehad
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150816/d70d9f6b/attachment-0001.html>