[PATCH 1/2] More precise comments

Henrik Brautaset Aronsen subsurface at henrik.synth.no
Thu Aug 20 01:03:57 PDT 2015


On Wed, Aug 19, 2015 at 7:12 PM, Miika Turkia <miika.turkia at gmail.com>
wrote:

> Signed-off-by: Miika Turkia <miika.turkia at gmail.com>
> ---
>  liquivision.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/liquivision.c b/liquivision.c
> index 957e7cc..91e0277 100644
> --- a/liquivision.c
> +++ b/liquivision.c
> @@ -387,9 +387,9 @@ int try_to_open_liquivision(const char *filename,
> struct memblock *mem)
>         unsigned int ptr;
>         int log_version;
>
> -       // Get name
> +       // Get name length
>         unsigned int len = array_uint32_le(buf);
>


Just a tiny question:  Why don't you just call the variable "name_length"?
No need for the comment then :)

Henrik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150820/36cc52e8/attachment.html>


More information about the subsurface mailing list