[PATCHES] Re: Problem with VPM-B in master

[Robert C. Helling]

Rick,

> On 21 Aug 2015, at 10:48, Rick Walsh <rickmwalsh at gmail.com> wrote:
> 
> It appears that the error didn't occur with the 100 m profile, but with shallow profiles that were calculated after entering gasses, but before entering all the depth information.  The red box with error messages wasn't visible while the planner was open, but is displayed after saving the plan.

thanks for catching this! It turned out, this could be triggered by opening the planner with VPM-B on an empty log and just changing the gas to OXYGEN (in fact any nitrox with >=78% oxygen).

This came about by a numerical instability when applying the Boyle law compensation when there is nothing to compensate for.

Here are two patches of which the first should fix the issue (at least it does for me). Please test carefully!

Best
Robert

PS: This happened to be quite hard to debug, took me >2h to fix.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150821/1fcf611e/attachment-0003.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Don-t-do-Boyle-compensation-when-still-on-first-stop.txt
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150821/1fcf611e/attachment-0002.txt>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150821/1fcf611e/attachment-0004.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-Don-t-do-computationally-expensive-Boyle-compensation-.txt
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150821/1fcf611e/attachment-0003.txt>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150821/1fcf611e/attachment-0005.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150821/1fcf611e/attachment-0001.sig>