[PATCH] Re: Test VPM-B

[Robert C. Helling]

Rick,

> On 27 Aug 2015, at 00:39, Rick Walsh <rickmwalsh at gmail.com <mailto:rickmwalsh at gmail.com>> wrote:
> 
> ^^^This last line changes the calculated plan but I don't know why.  I have attached the results of the test run twice: firstly with the current master (80e7213582c203a128270a0e2e8fcc850eede063), the second with the line vpmb_start gradient() removed.  Removing it improves the test results (passes 8/10 compared to 6/10, and one of the two failing is failing by 3 seconds using the within-1%+1min-of-vpmb-comparison-result-is-good-enough logic).  The results are replicated when the plan is calculated by running Subsurface properly.
> 
> My problem is that I can't work out why this line should have any effect at all.  Otherwise I would have sent a patch.  Do you understand what it's changing?

let me add to this confusion: In my branch, I had computed the first stop depth for each round of the CVA, as done in this patch:


This makes all but one test pass and even the fail I would say (looking at the spread sheet) actually passes but the comparison is for a wrong goal.

With this, when I now remove that vpmb_start_gradient I get a totally off test (which is what I remembered adding this line in the first place, I think it was to set the bottom pressure, but right now I haven’t gotten to confirm this). So, I would argue for taking this patch here and keeping the call.

Best
Robert
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150827/45dc368c/attachment.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Compute-first-stop-pressure-for-each-round-of-CVA.txt
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150827/45dc368c/attachment.txt>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150827/45dc368c/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150827/45dc368c/attachment.sig>