[PATCH] QML-UI: Remove button from dive details

Dirk Hohndel dirk at hohndel.org
Wed Dec 2 10:36:25 PST 2015


I agree

/D

On Wed, Dec 02, 2015 at 07:22:44PM +0100, Joakim Bygdell wrote:
> The button to hide the dive profile serves no purpose anymore.
> 
> Signed-off-by: Joakim Bygdell <j.bygdell at gmail.com>
> ---
>  qt-mobile/qml/DiveDetails.qml | 18 +-----------------
>  1 file changed, 1 insertion(+), 17 deletions(-)
> 
> diff --git a/qt-mobile/qml/DiveDetails.qml b/qt-mobile/qml/DiveDetails.qml
> index bff6453..b335631 100644
> --- a/qt-mobile/qml/DiveDetails.qml
> +++ b/qt-mobile/qml/DiveDetails.qml
> @@ -63,7 +63,7 @@ MobileComponents.Page {
>  						Item {
>  							Layout.columnSpan: 2
>  							Layout.fillWidth: true
> -							Layout.preferredHeight: qmlProfile.visible ? qmlProfile.height : profileHideButton.height
> +							Layout.preferredHeight: qmlProfile.height
>  							QMLProfile {
>  								id: qmlProfile
>  								height: MobileComponents.Units.gridUnit * 25
> @@ -74,22 +74,6 @@ MobileComponents.Page {
>  								}
>  								//Rectangle { color: "green"; opacity: 0.4; anchors.fill: parent } // used for debugging the dive profile sizing, will be removed later
>  							}
> -							Button {
> -								id: profileHideButton
> -								anchors {
> -									right: parent.right
> -									top: parent.top
> -								}
> -								text: "Hide Dive Profile"
> -								onClicked: {
> -									qmlProfile.visible = !qmlProfile.visible
> -									if (qmlProfile.visible) {
> -										text = "Hide Dive Profile"
> -									} else {
> -										text = "Show Dive Profile"
> -									}
> -								}
> -							}
>  						}
>  						MobileComponents.Label {
>  							Layout.alignment: Qt.AlignRight
> -- 
> 2.4.9 (Apple Git-60)
> 
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


More information about the subsurface mailing list