[PATCH] Correct selection after replanning a copy

Dirk Hohndel dirk at hohndel.org
Thu Dec 17 07:37:42 PST 2015


Hi Robert,

you are regressing a bit :-)

An email with just an attachment that's not considered text by my mail
reader... and once I work around that, the patch is clearly whitespace
damaged...

On Wed, Dec 16, 2015 at 10:50:42PM +0100, Robert Helling wrote:
>From fa15d0ac1d94e044f3f135f172ce8dccdddd3128 Mon Sep 17 00:00:00 2001
From: "Robert.Helling" <Helling at th-nb-tmpmbp05.fritz.box>
Date: Wed, 16 Dec 2015 22:47:10 +0100
Subject: [PATCH] Unselect source dive when saving a copy in replan

Then the user can select the two copies and merge them as two different
computers. Without this, the selection could is screwd up and there
is no option to merge in the context menu.

Signed-off-by: Robert C. Helling <helling at atdotde.de>
---
 qt-models/diveplannermodel.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/qt-models/diveplannermodel.cpp b/qt-models/diveplannermodel.cpp
index 5e23153..4b6d603 100644
--- a/qt-models/diveplannermodel.cpp
+++ b/qt-models/diveplannermodel.cpp
@@ -917,6 +917,7 @@ void DivePlannerPointsModel::createPlan(bool replanCopy)
 			struct dive *copy = alloc_dive();
 			copy_dive(current_dive, copy);
 			copy->id = 0;
+            copy->selected = false;
 			copy->divetrip = NULL;
 			if (current_dive->divetrip)
 				add_dive_to_trip(copy, current_dive->divetrip);
-- 
2.5.4 (Apple Git-61)


Can you guess the line that I think is wrong? :-)

Anyway, I'll take it and fix the whitespace. This is just a heads up that
there's a bit more configuring you may have to do on your new laptop :-)

/D


More information about the subsurface mailing list