[PATCH 2/3] ftdi: fix memory leak on error

Stephen Hemminger stephen at networkplumber.org
Sun Dec 27 14:33:17 PST 2015


Found by cppcheck. Minor memory leak if usb_reset fails

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 subsurface-core/serial_ftdi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/subsurface-core/serial_ftdi.c b/subsurface-core/serial_ftdi.c
index cbac026..ff13351 100644
--- a/subsurface-core/serial_ftdi.c
+++ b/subsurface-core/serial_ftdi.c
@@ -218,6 +218,7 @@ static dc_status_t serial_ftdi_open (serial_t **out, dc_context_t *context, cons
 	}
 
 	if (ftdi_usb_reset(ftdi_ctx)) {
+		free(device);
 		ERROR (context, "%s", ftdi_get_error_string(ftdi_ctx));
 		return DC_STATUS_IO;
 	}
-- 
2.1.4



More information about the subsurface mailing list