Broken build (for me)
Dirk Hohndel
dirk at hohndel.org
Mon Dec 28 08:28:06 PST 2015
On Mon, Dec 28, 2015 at 12:23:36PM +0200, "Paul-Erik Törrönen" wrote:
> commit 8c1cc4524d19e05b816f3388448cacd735d64504
> Author: Dirk Hohndel <dirk at hohndel.org>
> Date: Sun Dec 27 10:04:05 2015 -0800
>
> Don't reload identical data
>
> If we already have the same SHA loaded and no changes have been made
> to the
> dive list then there is no point in loading the dives again.
>
> Signed-off-by: Dirk Hohndel <dirk at hohndel.org>
>
> After this change, when starting Subsurface, I get no log view, and a
> message in the status bar states: Unable to look up revision '[]'
>
> Where the [] is actually a character looking like a box/square.
>
> In the console I have:
>
> already have loaded SHA (null) - don't load again
Ouch. Bad. Really stupid.
Yeah, I was so busy working on the Android app that I threw my common
sense out and didn't test any of this on the desktop. And it made a couple
of really stupid assumptions. Thanks for catching it.
Fix is about to be pushed. Well, this fixed it for me, please re-test.
/D
More information about the subsurface
mailing list