[PATCH] Fix Ubuntu glitch with completer popup
Miika Turkia
miika.turkia at gmail.com
Sun Feb 1 12:44:19 PST 2015
On Ubuntu, the completer often prevents applying/discarding the changes
on the dive info pane and disrupts editing of other fields as well. This
patch prevents the completer popup from appearing when not in edit mode
(apply or discard is pressed) or when the string is still empty.
Fixes #818
Signed-off-by: Miika Turkia <miika.turkia at gmail.com>
---
qt-ui/tagwidget.cpp | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/qt-ui/tagwidget.cpp b/qt-ui/tagwidget.cpp
index bfe5354..8365a2e 100644
--- a/qt-ui/tagwidget.cpp
+++ b/qt-ui/tagwidget.cpp
@@ -85,6 +85,14 @@ void TagWidget::reparse()
if (pos.first >= 0 && pos.second > 0)
currentText = text().mid(pos.first, pos.second - pos.first).trimmed();
+ /*
+ * Do not show the completer when not in edit mode - basically
+ * this returns when we are accepting or discarding the changes.
+ */
+ if (MainWindow::instance()->information()->isEditing() == false || currentText.length() == 0) {
+ return;
+ }
+
if (m_completer) {
m_completer->setCompletionPrefix(currentText);
if (m_completer->completionCount() == 1) {
--
1.9.1
More information about the subsurface
mailing list