[PATCH] Fix ssrf-version.h generation by cmake.
Dirk Hohndel
dirk at hohndel.org
Tue Feb 3 07:18:45 PST 2015
On Tue, Feb 03, 2015 at 09:06:09AM +0100, Patrick Valsecchi wrote:
> Hi,
>
> My previous cmake patch was relying on ssrf-version.h to be generated
> correctly by qmake, in the source directory. This one fixes the generation
> of this file in the build directory.
>
> I've tested by starting from a fresh GIT clone, creating a build directory
> outside of the clone, running "cmake" and "make" in it. It doesn't create
> any file in the source directory ("git clean -f -x" outputs nothing).
>
> CU
> From b5230059772d3f8845678618efb208a9f7da3498 Mon Sep 17 00:00:00 2001
> From: Patrick Valsecchi <patrick at thus.ch>
> Date: Tue, 3 Feb 2015 08:56:55 +0100
> Subject: [PATCH] Fix ssrf-version.h generation by cmake.
>
> Signed-off-by: Patrick Valsecchi <patrick at thus.ch>
Thanks - I'll test it later today (busy day here).
One request... better commit messages :-)
This time I copied part of your email above, but you really should have a
commit message that explains what is done and why and how.
/D
More information about the subsurface
mailing list