[PATCH] More tolerant about spaces in GPS coordinates.
Dirk Hohndel
dirk at hohndel.org
Wed Feb 4 10:53:46 PST 2015
On Wed, Feb 04, 2015 at 10:28:59AM +0100, Patrick Valsecchi wrote:
>
> OK, here is a total rewrite of the GPS coordinates parsing including UTs.
> It is a lot more flexible on the format and supports all the formats of the
> previous parser (AFAIK).
>
> I share your opinion on not including it in 4.4.
I just applied this. The code looks good with one exception... I really
don't like the
if (condition) return false;
formatting. That really hides the fact that there's a condition and exit
of the function (at least to my eyes). So I fixed that in your commit.
Kudos for adding tests. That's something we need to put a lot more focus
on.
/D
More information about the subsurface
mailing list