CCR mode and our implementation of the setpoint

[Dirk Hohndel]

On Sat, Feb 07, 2015 at 10:12:21AM +0100, Robert C. Helling wrote:
> 
> Have one header file where we define our own subsurface events (in
> addition to the libdivecomputer name space). We already have one for
> images. Currently it is not clear to me, if amongst the ldc events there
> is one that I should have used for set point changes (Jef, could you
> comment?) or if we have to create a new one for that. We will definitely
> need a new one for dive mode (OC, CCR, PSCR, FREEDIVE)

At least freedive is a dive type, isn't it? I am not interested in
pathological cases ("I freedove down to 80m, swam back up to 20m and there
started breathing from my buddies tank"). That said, we could of course
still model all four of them with an event at t=0 and then possibly events
later in time if there is a transition (e.g., bailout).

> In addition, have a function that maps event types upon reading
> subsurface files. A SAMPLE_EVENT_PO2 is mapped to the other event, if it
> occurs at t=0 or if it comes from a dive computer that has no high/low
> warnings.

OK

> In fact, from a git grep SAMPLE_EVENT_PO2 in the libdivecomputer
> sources, the warning events can only come from Atomics Cobalt, OSTC, and
> Suunto D9. And for the OSTC it is not even clear to me that this is not
> using the double meaning as well. So the list of exceptions is rather
> short.

You are missing the EON Steele. Not sure if that's in libdivecomputer
master, yet, it's definitely in Subsurface-testing. And OSTC is a warning
just like the others. I checked.

/D