Request For Comments - Undo/Redo framework

[Dirk Hohndel]

Hi Grace,

On Tue, Feb 10, 2015 at 12:23:27PM +0300, Grace Karanja wrote:
> > pardon my ignorance... what does the "aboutToShow()" signal do?
> > Ahh, I think I got it, see below...
> >
> > I'm guessing the aboutToShow allows us to mess with the menu just before
> > it gets shown? How do we deal with this when hotkeys are used?
> 
> I think for hot keys  the aboutToShow won't work. I will have to come up
> with a workaround.

Most software simply just ignores the undo/redo keys if there are no more
steps to be done. I guess that will work for us as well.

> > So what's the summary.
> >
> > First, thanks for working on this. It's a complex piece of code that will
> > take some work to get right and I'm very glad you are stepping up to do
> > this.
> >
> > I think there is room to make the API better - it will make the code
> > cleaner and the user experience better. But it seems like a step in the
> > right direction.
> >
> > Especially early on in the release cycle (like right now, right after a
> > release - in what Linus would call the merge window) I'm willing to take
> > code and push it into master even if I have concerns and want stuff
> > reworked. I'll assume that you will continue to work on this and will
> > consider the changes that I have requested and I'll apply these patches
> > and push them out. After all, based on my testing they do in fact
> > implement a working undo for deleting dives :-)
> > On the flip side, redo() gives me a crash :-(
> 
> Thanks.

You are welcome. I just noticed that I had forgotten to push last night -
I just did that, so your changes are now in master

/D