Merging Dives (P.S. -- multiple email addresses)

[Steve Butler]

On 02/15/2015 05:46 PM, Dirk Hohndel wrote:
> On Sun, Feb 15, 2015 at 05:41:13PM -0800, Dirk Hohndel wrote:
>> I see... because of the rules for merging dives dive 1 and 2 can't be
>> merged - more than 30 minutes between the end of the first and the
>> beginning of the second. Then dives 2 and 3 get merged successfully.
>> And then we seem to have a bug because the duration of that merged dive is
>> now incorrect. It claims a duration of 850 seconds - a little over 14
>> minutes, which is the sum of the two durations, but not the sum duration
>> from beginning to end of the dive - we don't account for the surface
>> interval. And therefore a calculated end time is about ten minutes to
>> early and with that the merge fails.
> Ahhhhh I see what bites us. We calculate duration from the samples. And at
> some point we decided that we don't want to include surface intervals in
> the duration (because that messes with the SAC rate calculation). But of
> course that also means that when+duration isn't the end time of the dive.
> So we need a dive duration and a total time field.
>
> I don't have the time to implement this right now, but at least I
> understand the bug now.
>
> /D
>

No hurry from here.