Merging Dives (P.S. -- multiple email addresses)

[Dirk Hohndel]

On Sun, Feb 15, 2015 at 07:55:13PM -0800, Steve Butler wrote:
> >But for every pair of dives it's supposed to merge it calls
> >can_merge() and that only succeeds if there's less than 30 minutes between
> >the dives...
> One of these days I'll read the manual.  Last time I read a manual though, I
> ended up in a timed 4-hour test.

I promise, there's no test, timed or otherwise.

> >You should ask yourself why you want to merge these dives to begin with...
> >the idea behind merging was if you did a dive but for some reason had to
> >come to the surface and the silly computer decides to start a new dive,
> >whereas in reality you are just continuing the dive. > 30 minutes on the
> >surface seems not to fit that pattern.
> Since we were in the water all 5 hours (she on one AL-64), she wanted them
> all combined.  Now we know and she'll live with what we did manage to merge.

Just for the record, it's really easy to just merge them in the XML.
Or you could recompile with a 60 minute limit (or no limit) and it would
all work as well.

> As for me, I'm going to delete the pool dives and keep only the paper copy
> the instructor signs!

I have one pool dive in my log - and looking back I have no idea why I
kept it :-)

> The two OW dives last Sunday ended up being all surface scenarios. Final
> three ocean dives next Sunday.  Then we'll both be rescue diver certified.

I have one of my dives from the rescue class in my log as well. Total
duration 90 seconds. Down to 24ft / 7m, find unconscious (simulated, of
course) diver, quickly get him to the surface, swim him out to the shore
and drag him on land :-)

> I think it happened last week and you may have fixed it be default then.

Entirely possible. When I see emails held for moderation that come just
from other addresses of subscribed members, or even from non-members but
are actually Subsurface related and not spam, I simply add those addresses
to the accept list. The only reason we have the "members only" limit is in
order to cut down on SPAM. Even with a spam filter sitting in front of all
this I end up with an average of about 30 emails a day that get held by
the members only filter. And most days 100% of them are spam indeed.

/D