problems compiling subsurface 4.4 on fedora 18

[Lubomir I. Ivanov]

On 17 February 2015 at 03:27, Michele Fabi <fabiemme at gmail.com> wrote:
> This is the laptop I use for work (and all the rest :) and I procrastinated
> the upgrade for lack of time and a bit of laziness. F18 is ok for all I
> need. (well, it was...)
> Another reason for using git version is that my dive computer is a
> Divesystem Orca (very similar to the iDive) that is currently supported by
> libdivecomputer but is not in the "official" list of supported computer by
> subsurface.
> Here the result of compiling following Lubomir suggestions. Ill'upgrade the
> machine as soon as possible.

if you haven't updated yet, you can save locally the raw email / patch
i've just sent to the mailing list:
[PATCH] simplewidgets.cpp: QLineEdit::setClearButtonEnabled() is from Qt5.2

move it to the Subsurface source folder and do:
git am <patch-file>

then call 'make' again to see if the QLineEdit error is fixed.
i'm assuming you have Qt < 5.2.0

> git-access.c: In function ‘update_local_repo’:
> git-access.c:87:2: warning: implicit declaration of function
> ‘git_remote_fetch’ [-Wimplicit-function-declaration]

looks like libgit2 is very outdated and the build will also most
likely fail because of it.

git_remote_fetch() was added in fe3a40a4ff056400cde6 which is from
2013-09-16 (v0.20).
we can probably make this work by sending patches for you to test, but
instead a system update is much more viable.

> compiling libdivecomputer.c
> compiling liquivision.c
> liquivision.c: In function ‘try_to_open_liquivision’:
> liquivision.c:303:36: warning: ‘event.pressure.mbar’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> liquivision.c:244:19: note: ‘event.pressure.mbar’ was declared here
> liquivision.c:301:27: warning: ‘event.time’ may be used uninitialized in
> this function [-Wmaybe-uninitialized]
> liquivision.c:244:19: note: ‘event.time’ was declared here
> liquivision.c:140:42: warning: ‘location’ may be used uninitialized in this
> function [-Wmaybe-uninitialized]

<snip>

> qt-ui/diveplanner.cpp: In member function ‘void
> DivePlannerPointsModel::createSimpleDive()’:
> qt-ui/diveplanner.cpp:65:26: warning: missing braces around initializer for
> ‘fraction_t’ [-Wmissing-braces]
> qt-ui/diveplanner.cpp: In member function ‘virtual bool
> DivePlannerPointsModel::setData(const QModelIndex&, const QVariant&, int)’:
> qt-ui/diveplanner.cpp:660:26: warning: missing braces around initializer for
> ‘fraction_t’ [-Wmissing-braces]
> qt-ui/diveplanner.cpp: In member function ‘int
> DivePlannerPointsModel::addStop(int, int, gasmix*, int, bool)’:
> qt-ui/diveplanner.cpp:942:26: warning: missing braces around initializer for
> ‘fraction_t’ [-Wmissing-braces]
> qt-ui/diveplanner.cpp:943:26: warning: missing braces around initializer for
> ‘fraction_t’ [-Wmissing-braces]
> compiling qt-ui/downloadfromdivecomputer.cpp
> compiling qt-ui/globe.cpp
> qt-ui/globe.cpp: In member function ‘void
> GlobeGPS::changeDiveGeoPosition(qreal, qreal,
> Marble::GeoDataCoordinates::Unit)’:
> qt-ui/globe.cpp:321:20: warning: unused variable ‘ds’ [-Wunused-variable]

<snip>

> qt-ui/printlayout.cpp: In member function ‘void PrintLayout::printTable()’:
> qt-ui/printlayout.cpp:394:4: warning: ‘headingRowHeight’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> qt-ui/printlayout.cpp:382:83: note: ‘headingRowHeight’ was declared here
> In file included from /usr/include/qt5/QtCore/qrect.h:46:0,
>                  from /usr/include/qt5/QtCore/qmargins.h:45,
>                  from /usr/include/qt5/QtWidgets/qwidget.h:47,
>                  from /usr/include/qt5/QtWidgets/qdesktopwidget.h:45,
>                  from /usr/include/qt5/QtWidgets/QDesktopWidget:1,
>                  from qt-ui/printlayout.cpp:2:
> /usr/include/qt5/QtCore/qpoint.h:278:64: warning: ‘headingRowHeightD2’ may
> be used uninitialized in this function [-Wmaybe-uninitialized]
> qt-ui/printlayout.cpp:382:63: note: ‘headingRowHeightD2’ was declared here
> compiling qt-ui/printoptions.cpp
> compiling qt-ui/simplewidgets.cpp
> qt-ui/simplewidgets.cpp: In constructor ‘TagFilter::TagFilter(QWidget*)’:
> qt-ui/simplewidgets.cpp:509:25: error: ‘class QLineEdit’ has no member named
> ‘setClearButtonEnabled’
> qt-ui/simplewidgets.cpp: In constructor
> ‘BuddyFilter::BuddyFilter(QWidget*)’:
> qt-ui/simplewidgets.cpp:536:25: error: ‘class QLineEdit’ has no member named
> ‘setClearButtonEnabled’
> qt-ui/simplewidgets.cpp: In constructor
> ‘LocationFilter::LocationFilter(QWidget*)’:

interesting warnings. i don't have these with -Wall on gcc 4.8.2.

lubomir
--