[PATCH] More tolerant about spaces in GPS coordinates.

Davide DB dbdavide at gmail.com
Sun Feb 22 11:12:28 PST 2015


I realized that coordinates copied directly from xml file are not
recognized if  pasting them into coordinates input field.
It doesn't like the lacking of N E references. Sadly google maps recognize
them.

davide at mobile
Il 22/feb/2015 19:24 "Patrick Valsecchi" <patrick at thus.ch> ha scritto:

>  On 22. 02. 15 17:52, Miika Turkia wrote:
>
>  On Wed, Feb 4, 2015 at 11:28 AM, Patrick Valsecchi <patrick at thus.ch>
> wrote:
>
>> On 02/03/2015 04:41 PM, Dirk Hohndel wrote:
>>
>>> On Tue, Feb 03, 2015 at 04:32:40PM +0100, Patrick Valsecchi wrote:
>>>
>>>> Hi,
>>>>
>>>> This is a tentative to make subsurface a bit more flexible when parsing
>>>> GPS
>>>> coordinates. I like to geo-reference my dives, but copy and pasting the
>>>> coordinates from web sites was quite a pain (needed a lot of manual
>>>> correction).
>>>>
>>>> Please have a look and comment. I'm quite tempted to go wild and do
>>>> another
>>>> rewrite without using regular expressions... would be more flexible and
>>>> less
>>>> code, IMHO.
>>>>
>>> Absolutely. By all means, please rewrite it without regular expression if
>>> that makes it more flexible.
>>>
>>> Given where we are in the testing cycle, I won't apply this fix to
>>> master.
>>> I'm hoping to cut 4.4 in the next day or two and there's no way this will
>>> get enough testing.
>>>
>>
>>  OK, here is a total rewrite of the GPS coordinates parsing including UTs.
>> It is a lot more flexible on the format and supports all the formats of
>> the previous parser (AFAIK).
>>
>> I share your opinion on not including it in 4.4.
>>
>
>  Do you care to work on the GPS parsing a bit more? We have some requests
> for more lax parsing on our user forum:
>
>
> https://groups.google.com/forum/#!category-topic/subsurface-divelog/pMPlpNvhmfw
>
> E.g. 48 51.491n 2 17.677e
>
>
> No problem. I'll come up with a patch in the next days.
>
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150222/4c79d5bc/attachment-0001.html>


More information about the subsurface mailing list