Request For Comments - Undo/Redo framework

[Grace Karanja]

On Thu, Feb 26, 2015 at 8:11 PM, Dirk Hohndel <dirk at hohndel.org> wrote:

> Hi Grace...
>
> Careful - you are ignoring the selectedOnly flag... so the condition
> should be   if (!selected_only || dive->selected)
>
> > +                             renumberedDives.insert(dive->id,
> dive->number);
> > +                     }
> > +             }
> > +             UndoRenumberDives *undoCommand = new
> UndoRenumberDives(renumberedDives, ui.spinBox->value());
> > +             MainWindow::instance()->undoStack->push(undoCommand);
> >               renumber_dives(ui.spinBox->value(), selectedOnly);
>
> Oh, so this time you ARE calling the activity function from here instead
> of having the redo registration take care of that. That feels a little
> inconsistent with your last patch...
>
>
>
My bad...I will rework the patch and resend it.


>
> /D
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150226/3aa26c68/attachment-0001.html>