Current subsurface breakage

Linus Torvalds torvalds at linux-foundation.org
Fri Jan 2 22:22:36 PST 2015


On Fri, Jan 2, 2015 at 9:35 PM, Linus Torvalds
<torvalds at linux-foundation.org> wrote:
>
> I'll take a look at the odd cylinder switch thing next.

Ok, I really can't make any sense of what the code tried to do, but it
was complicated and insane.

Rather than try to make sense of what it was doing digging into the
model data, the attached patch just does the sane thing, which makes
things work.

I don't have explicit cylinder numbers for the gas switch events - or
rather, I *do* have them, because it's what the EON Steel internally
uses, but the libdivecomputer interface with the crazy gasmix approach
doesn't allow me to pass those ones. So I've not tested that part, but
now the code is so trivial that I dare say it should work too. So if
you have an explicit cylinder number, the tooltip should now say

   gaschange: EAN40 (cyl 2)

which means that it's switching to cylinder 2 (which is EAN40).
Without the explicit cylinder number, it's just "gaschange: EAN40"
like it was before.

Anyway, with this, my EON Steel data shows correctly, so my next email
will be the libdivecomputer patch to get gaschanges from the EON
Steel.

                            Linus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-gaschange-tooltip-information.patch
Type: text/x-patch
Size: 2273 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150102/b932d85a/attachment.bin>


More information about the subsurface mailing list