[PATCH] Show setpoint values on po2 graph (Version 2)
Dirk Hohndel
dirk at hohndel.org
Mon Jan 5 09:20:58 PST 2015
On Mon, Jan 05, 2015 at 09:20:26AM +0200, Willem Ferguson wrote:
>
> This is version 2 of this patch.
> When a CCR dive is viewed and the toolbar button for PO2 is activated,
> both the PO2 (green line) and the O2 setpoint (red line) are shown.
> This allows evaluation of the PO2 in the CCR loop with respect to the
> pre-configured O2 setpoint.
>
> The setpoint graph can be disabled from the Preferences/Graphs tab
> by checking the appropriate checkbox. By default the box is checked.
I turned this off by default.
> Most of Dirk's comments on the first version of this patch are
> addressed here.
Thanks. I took this patch. One question:
> @@ -977,6 +987,7 @@ void ProfileWidget2::setProfileState()
> }
> pn2GasItem->setVisible(prefs.pp_graphs.pn2);
> po2GasItem->setVisible(prefs.pp_graphs.po2);
> + o2SetpointGasItem->setVisible(true);
Is that correct? Shouldn't this be
o2SetpointGasItem->setVisible((current_dc->dctype == CCR) && (prefs.show_ccr_setpoint));
??
/D
More information about the subsurface
mailing list