[PATCH] Minor code cleanup in profilewidget2.cpp
Joakim Bygdell
j.bygdell at gmail.com
Fri Jan 9 10:06:50 PST 2015
> On 09 Jan 2015, at 18:15, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> On Fri, Jan 09, 2015 at 09:08:26AM +0200, Willem Ferguson wrote:
>>
>> 1) Delete a few commented-out lines that I created myself.
>
> I'll do this in the initial commit when applying it.
>
>> 2) Delete two groups of 4 instructions which are duplicated in the existing
>> code.
>
> Are you certain those aren't needed. We frequently end up having the same
> code in multiple places as different code paths end up needing to do the
> same thing. I'm a bit uncomfortable with a patch that just removes random
> code without a better explanation how these specific actions are
> redundant. The simple fact that the same code shows up elsewhere isn't
> sufficient.
>
That code needs to be in those two locations, one is executed when you interact with the profile.
The other when a dive is selected and everything is initiated.
/Jocke
More information about the subsurface
mailing list