[PATCH] Ignore QWebView in Android

Anton Lundin glance at acc.umu.se
Tue Jan 13 09:20:18 PST 2015


On 13 January, 2015 - Joseph W. Joshua wrote:

> Ignore QWebView instances in the preferences dialog when compiling under
> Android, as QWebView is not yet supported under Android.


Nice. I was planning on doing something like this, but i got lazy.
Thanks for stepping up and doing it.


> @@ -20,6 +24,15 @@ PreferencesDialog *PreferencesDialog::instance()
>  PreferencesDialog::PreferencesDialog(QWidget *parent, Qt::WindowFlags f) : QDialog(parent, f)
>  {
>  	ui.setupUi(this);
> +#ifndef Q_OS_ANDROID
> +	facebookWebView = new QWebView(this);
> +	QVBoxLayout fbLayout(ui.page_6);
> +	fbLayout.addWidget(facebookWebView);
> +	fbLayout.addWidget(ui.fbConnected);
> +	ui.page_6->setLayout(&fbLayout);

Can you rename page_6 to something better?

> +#else
> +	delete ui.listWidget->item(5);
> +#endif

Is there a better way than addressing it as 5?

Feels like that one can break as soon as someone touches the ui file
again.


//Anton


-- 
Anton Lundin	+46702-161604


More information about the subsurface mailing list