[PATCH 1/7] Refactor device handling threads

[Thiago Macieira]

On Tuesday 20 January 2015 23:34:59 Anton Lundin wrote:
> It's part of the whole get-progress-events series, and I thought using a
> common ancestor to all those classes made it easier to implement the
> whole progress event thingie.
> 
> That way i can have them all behave the same way in that respect.
> 
> 
> I also have some unfinished code for generating trace logs from
> different actions for debugging purposes. I've used it my self to
> diagnose some older bugs, but its kinda rough, and I haven't had the
> time to clean that code up. (And it hasn't bin needed to get any debug
> logs from users yet...)
> 
> 
> Does that make more sense?

Yes, it does.

It's just that a quick look at the progress patches didn't seem to require the 
common ancestor.

Wait, I see it now in patch 3. The callback is in DeviceThread.

Never mind, nothing to see here...


Useless trivia (and at the risk of making Dirk and Linus hate C++ even more): 
passing a C++ static method as a callback to a C function is not standards-
compliant. The callback should be a non-member static function inside an 
extern "C" block.

No, don't do that. This is useless.
-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358