CSV import crash

[Tomaz Canabrava]

On Thu, Jan 29, 2015 at 5:47 PM, Robert Helling <helling at atdotde.de> wrote:

> Hi,
>
> On 29 Jan 2015, at 20:01, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> And it doesn't crash on my Mac, either.
>
> Can you give more data? Which git version of Subsurface? How did you build
> it (i.e., which Qt, what tool chain)? Can you reproduce this with the
> daily binaries from this morning?
>
>
> it does crash for me. The last subsurface code on the stack is line 437 of
> divelogimportdialog.cpp
>
> 			headers.replace(CSVApps[value].time, tr("Sample time"));
>
>
> I have no idea, what this is but I can tell CSCApps is != NULL, value == 3
>  and there the assertion
>
>     Q_ASSERT_X(i >= 0 && i < p.size(), "QList<T>::replace", "index out of range");
>
>
> of the replace method fails with „index out of range“ as headers has only
> one item.
>

Most probably the issue is the wrong separator, splitting the data with ','
or ';' may have it caused to have just the first item that contained
everything,
and trying to acces .time (three) made an invalid index.

I *think* we should try to split with another separator if splitString.size
== 1


>
> Let me know what else to look for.
>
> Best
> Robert
>
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150129/8fd59da4/attachment.html>