[PATCH] Prevent crash on shutdown

Anton Lundin glance at acc.umu.se
Fri Jan 30 06:37:11 PST 2015


We always call reply->deleteLater(), so we where actually calling delete
on a stale pointer, that caused subsurface to crash on shutdown.

Reported-by: Sergey Starosek <sergey-starosek at yandex.ru>
Signed-off-by: Anton Lundin <glance at acc.umu.se>
---
 qt-ui/diveshareexportdialog.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/qt-ui/diveshareexportdialog.cpp b/qt-ui/diveshareexportdialog.cpp
index 3ce2e0b..9e8e69a 100644
--- a/qt-ui/diveshareexportdialog.cpp
+++ b/qt-ui/diveshareexportdialog.cpp
@@ -19,7 +19,6 @@ DiveShareExportDialog::DiveShareExportDialog(QWidget *parent) :
 DiveShareExportDialog::~DiveShareExportDialog()
 {
 	delete ui;
-	delete reply;
 }
 
 void DiveShareExportDialog::UIDFromBrowser()
-- 
2.1.0



More information about the subsurface mailing list