[PATCH] Don't go to edit mode if the dive notes field didn't change.

[Gehad Elrobey]

I forgot to check for the empty value in the two conditions, patch
re-attached.

Regards,
Gehad

On Fri, Jan 30, 2015 at 10:47 PM, Miika Turkia <miika.turkia at gmail.com>
wrote:

> On Fri, Jan 30, 2015 at 10:40 PM, Gehad Elrobey <gehadelrobey at gmail.com>
> wrote:
>
>> The main-tab view is inconsistent as mentioned in #804, this patch fixes
>> the notes view.
>>
>
> I get crashes when applying this patch. This occurs when I attempt to
> write to the notes field or focus leaves it.
>
> Program received signal SIGSEGV, Segmentation fault.
> __strcmp_ssse3 () at ../sysdeps/x86_64/multiarch/../strcmp.S:209
> 209    ../sysdeps/x86_64/multiarch/../strcmp.S: No such file or directory.
> (gdb) bt
> #0  __strcmp_ssse3 () at ../sysdeps/x86_64/multiarch/../strcmp.S:209
> #1  0x00000000004ae01e in MainTab::on_notes_textChanged (this=0xb19450) at
> ../qt-ui/maintab.cpp:1167
> #2  0x0000000000588299 in MainTab::qt_static_metacall (_o=0xb19450,
> _c=QMetaObject::InvokeMetaMethod, _id=14, _a=0x7fffffffcc50) at
> .moc/moc_maintab.cpp:237
> #3  0x0000000000588784 in MainTab::qt_metacall (this=0xb19450,
> _c=QMetaObject::InvokeMetaMethod, _id=14, _a=0x7fffffffcc50) at
> .moc/moc_maintab.cpp:327
> #4  0x00007ffff521636d in QMetaObject::activate(QObject*, int, int,
> void**) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
>
> miika
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150130/c39b45a4/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Don-t-go-to-edit-mode-if-the-dive-notes-field-didn-t.patch
Type: text/x-patch
Size: 1467 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150130/c39b45a4/attachment.bin>