[PULL REQUEST] libdivecomputer - Subsurface-testing branch
dirk at hohndel.org
Mon Jul 6 08:20:19 PDT 2015
On Mon, Jul 06, 2015 at 06:07:02PM +0300, Lubomir I. Ivanov wrote:
> On 6 July 2015 at 17:33, Claudiu Olteanu
> <olteanu.vasilica.claudiu at gmail.com> wrote:
> > Hi,
> > These patches create a generic way to represent any type of serial
> > communication. They are used to create a custom serial implementation
> > for HW_OSTC3 and SHEARWATER families.
> hey, Claudiu.
> just to point out that if you attach the patches in the email, it's
> not a git pull-request. but AFAIK, pull-requests are not mandatory for
Both true. I prefer emails with patches to have [PATCH] in their subject
because that makes it much easier for me to find them.
Pull requests have advantages for GSoC purposes as they make it much
easier for me to ask the mentor to go through them, sign off on the
patches and then I can pull them. But as Lubomir said, that's optional.
More information about the subsurface