[PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

Thiago Macieira thiago at macieira.org
Mon Jul 6 14:02:54 PDT 2015


On Monday 06 July 2015 23:19:58 Claudiu Olteanu wrote:
> > +       bool on = !(mode == QBluetoothLocalDevice::HostPoweredOff);
> 
> That's slightly weird :-)
> 
> I know that this is weird but there is no HostPoweredOn enum :-). It can be
> either off, connectable, discoverable or discoverable limited inquiry.
> Therefore I choose to use !(mode == QBluetoothLocalDevice::HostPoweredOff))
> instead of (mode == QBluetoothLocalDevice::HostDiscoverable || mode ==
> QBluetoothLocalDevice::HostConnectable || ..)

I meant doing

	bool on = !(x == y);

instead of

	bool on = x != y;

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358



More information about the subsurface mailing list