[PULL REQUEST] VPM-B Attempt 2.

Rick Walsh rickmwalsh at gmail.com
Tue Jul 7 03:41:56 PDT 2015


Dirk, Jan,

On 5 July 2015 at 23:56, Dirk Hohndel <dirk at hohndel.org> wrote:

> On Sat, Jul 04, 2015 at 12:27:23AM +0200, Jan Darowski wrote:
> > Hi,
> > Here is another pull request. I hope now it's better. Everything was
> > reorganized from scratch, the final code is almost the same.
>
> I like the patches much better.
> I agree with Robert that you could have squashed a couple together, but in
> the end I felt it was better to just pull what you had.
>
>
I've reattached the patch to use the same VPM configuration parameters used
in other programs.  This is necessary to match Eric Baker's 'benchmark'
dive profile.  The patch is the same as before, but hopefully with a better
commit message and line wrapping.

I assume this was overlooked rather than deliberately omitted before, but
do say if there's a reason why it shouldn't be applied now.

The second patch adds units to the structure comments (but not in the
variable names).  I'm confused by the units for surface_tension_gamma and
skin_compression_gammaC.  According to
http://www.deepocean.net/deepocean/index.php?science04.php
surface_tension_gamma = 17.9 dyn/cm = 0.179 N/m, but 17.9 dyn/cm = 0.0179
N/m
surface_tension_gamma = 257 dyn/cm = 2.57 N/m, but 257 dyn/cm = 0.257 N/m

My previous version of the patch gave the unit as mN/cm, but I'm not sure
that's right either.

As Jan noted before, it isn't the first error on that page.  However, the
calculated profile matches the benchmark, so something must be right (or
unit errors are cancelling each other out).

Cheers,

Rick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150707/0ee9baf7/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-common-VPM-configuration-parameters.patch
Type: text/x-patch
Size: 1326 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150707/0ee9baf7/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Include-units-in-VPM-config-structure-definition.patch
Type: text/x-patch
Size: 1913 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150707/0ee9baf7/attachment-0003.bin>


More information about the subsurface mailing list