Linking error with recent libdc

[Dirk Hohndel]

On Tue, Jul 07, 2015 at 08:51:52PM -1000, Gaetan Bisson wrote:
> [2015-07-07 20:35:14 -1000] Gaetan Bisson:
> > [2015-07-07 20:21:49 -1000] Gaetan Bisson:
> > > Building subsurface master against that still fails for me.
> > 
> > So things work as expected if I compile libdc without build flags.
> > 
> > Our build system uses:
> > 
> > CPPFLAGS="-D_FORTIFY_SOURCE=2"
> > CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong --param=ssp-buffer-size=4"
> > CXXFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong --param=ssp-buffer-size=4"
> > LDFLAGS="-Wl,-O1,--sort-common,--as-needed,-z,relro"
> > 
> > And apparently one of them makes libdc unhappy... I'll narrow it down
> > and report back.
> 
> Forget that.
> 
> As I said in my reply to Jef's message, the build system "issue" I had
> was throwing away the static library.

Ah, that explains it. We always link statically against libdivecomputer on
all the platforms that I build binaries for.

Arch is the one platform that builds their own that tracks master.

/D