Another Subsurface crash

[Rick Walsh]

I've finally been catching up on assigning locations to my last 150 odd
dives in Subsurface.  Wow that's a huge effort, but I've got there.

I've been working with the latest master (commit
d8ca04626589221c5f7c178e882cfaa4c095ce2a, Author: Dirk Hohndel <
dirk at hohndel.org>, Date:   Fri Jul 10 13:28:28 2015 -0700), and built
everything in a clean directory with build.sh a few hours ago.

Most things are working great, including really useful features I have
barely tested before, such as the filtering (awesome), editing multiple
dives at once, and location management.

I have a couple of annoyances with the Marble behaviour.
Firstly, it keeps zooming out when I right-click to edit the location of a
site that doesn't yet have coordinates.

Secondly, I repeatedly try to use Marble to set coordinates for a dive that
doesn't have a location set.  It allows me to right-click and select 'edit
location', but then it won't let me double click to choose a new location.
I worked out that it's because I haven't yet named the site, which makes
some sense, but it would be good if there were a message in Marble
prompting me to name the site first.  Especially because once I work out my
mistake, it inevitably zooms out to somewhere over Africa, so I have to
zoom and pan to find my way back to whatever little site I'd carefully
zoomed to previously in Australia/Asia/New Zealand.

But the real problem is I'm getting crashes as seemingly random intervals.
It seems to happen when I'm either selecting a different site from the
list, merging dives, or editing multiple dives.  Most of the time it
doesn't crash, so it's hard to repeat.  Backtrace (copied below in full)
and memory map (first few lines copied) are helpfully printed to the
command terminal.  It doesn't mean much to me, but it hopefully it does to
someone.

Running Fedora 22 with Qt 5.4.2 (from Fedora repositories).

[rick at localhost build]$ ./subsurface
Map theme file does not exist: ""
QInotifyFileSystemWatcherEngine::addPaths: inotify_add_watch failed: No
such file or directory
*** Error in `./subsurface': free(): invalid size: 0x00000000034d3e30 ***
======= Backtrace: =========
/lib64/libc.so.6(+0x77e9d)[0x7fec7ba06e9d]
/lib64/libc.so.6(+0x7f53c)[0x7fec7ba0e53c]
/lib64/libc.so.6(cfree+0x4c)[0x7fec7ba12e9c]
./subsurface(free_taxonomy+0x45)[0x6ca9df]
./subsurface(copy_dive_site+0xd7)[0x67f009]
./subsurface(_ZN7MainTab14updateDiveInfoEb+0x959)[0x5e3e29]
./subsurface(_ZN10MainWindow20current_dive_changedEi+0x56)[0x4fafd0]
./subsurface[0x5a1532]
/lib64/libQt5Core.so.5(_ZN11QMetaObject8activateEP7QObjectiiPPv+0x7ba)[0x7fec7c59807a]
./subsurface(_ZN12DiveListView18currentDiveChangedEi+0x46)[0x59e098]
./subsurface(_ZN12DiveListView16selectionChangedERK14QItemSelectionS2_+0x74d)[0x5b934f]
/lib64/libQt5Widgets.so.5(+0x3abf01)[0x7fec7d72df01]
/lib64/libQt5Core.so.5(_ZN11QMetaObject8activateEP7QObjectiiPPv+0x7ba)[0x7fec7c59807a]
/lib64/libQt5Core.so.5(_ZN19QItemSelectionModel16selectionChangedERK14QItemSelectionS2_+0x37)[0x7fec7c5189b7]
/lib64/libQt5Core.so.5(_ZN19QItemSelectionModel20emitSelectionChangedERK14QItemSelectionS2_+0x22c)[0x7fec7c51cddc]
/lib64/libQt5Core.so.5(_ZN19QItemSelectionModel6selectERK14QItemSelection6QFlagsINS_13SelectionFlagEE+0x1d6)[0x7fec7c51f256]
/lib64/libQt5Core.so.5(_ZN19QItemSelectionModel6selectERK11QModelIndex6QFlagsINS_13SelectionFlagEE+0x3c)[0x7fec7c51a84c]
/lib64/libQt5Core.so.5(_ZN19QItemSelectionModel15setCurrentIndexERK11QModelIndex6QFlagsINS_13SelectionFlagEE+0x1a4)[0x7fec7c518d94]
/lib64/libQt5Widgets.so.5(_ZN17QAbstractItemView13keyPressEventEP9QKeyEvent+0x9b7)[0x7fec7d72c627]
/lib64/libQt5Widgets.so.5(_ZN9QTreeView13keyPressEventEP9QKeyEvent+0x6b)[0x7fec7d773b5b]
/lib64/libQt5Widgets.so.5(_ZN7QWidget5eventEP6QEvent+0x997)[0x7fec7d517347]
/lib64/libQt5Widgets.so.5(_ZN6QFrame5eventEP6QEvent+0x1e)[0x7fec7d6115de]
/lib64/libQt5Widgets.so.5(_ZN19QAbstractScrollArea5eventEP6QEvent+0x373)[0x7fec7d694483]
/lib64/libQt5Widgets.so.5(_ZN17QAbstractItemView5eventEP6QEvent+0x8b)[0x7fec7d73451b]
/lib64/libQt5Widgets.so.5(_ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent+0x8c)[0x7fec7d4d47ec]
/lib64/libQt5Widgets.so.5(_ZN12QApplication6notifyEP7QObjectP6QEvent+0x939)[0x7fec7d4da429]
/lib64/libQt5Core.so.5(_ZN16QCoreApplication14notifyInternalEP7QObjectP6QEvent+0xdb)[0x7fec7c56767b]
/lib64/libQt5Widgets.so.5(+0x1ae5f3)[0x7fec7d5305f3]
/lib64/libQt5Widgets.so.5(_ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent+0x8c)[0x7fec7d4d47ec]
/lib64/libQt5Widgets.so.5(_ZN12QApplication6notifyEP7QObjectP6QEvent+0x3a0)[0x7fec7d4d9e90]
/lib64/libQt5Core.so.5(_ZN16QCoreApplication14notifyInternalEP7QObjectP6QEvent+0xdb)[0x7fec7c56767b]
/lib64/libQt5Gui.so.5(_ZN22QGuiApplicationPrivate15processKeyEventEPN29QWindowSystemInterfacePrivate8KeyEventE+0xd7)[0x7fec7cd2e9d7]
/lib64/libQt5Gui.so.5(_ZN22QGuiApplicationPrivate24processWindowSystemEventEPN29QWindowSystemInterfacePrivate17WindowSystemEventE+0x115)[0x7fec7cd33975]
/lib64/libQt5Gui.so.5(_ZN22QWindowSystemInterface22sendWindowSystemEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE+0x28)[0x7fec7cd18de8]
/usr/lib64/qt5/plugins/platforms/libqxcb.so(+0x5c600)[0x7fec66638600]
/lib64/libglib-2.0.so.0(g_main_context_dispatch+0x15a)[0x7fec76462a8a]
/lib64/libglib-2.0.so.0(+0x49e20)[0x7fec76462e20]
/lib64/libglib-2.0.so.0(g_main_context_iteration+0x2c)[0x7fec76462ecc]
/lib64/libQt5Core.so.5(_ZN20QEventDispatcherGlib13processEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE+0x5f)[0x7fec7c5beb6f]
/lib64/libQt5Core.so.5(_ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE+0x10a)[0x7fec7c564eba]
/lib64/libQt5Core.so.5(_ZN16QCoreApplication4execEv+0x9c)[0x7fec7c56ca2c]
./subsurface(_Z6run_uiv+0x1d)[0x4e1356]
./subsurface(main+0x484)[0x4e02fa]
/lib64/libc.so.6(__libc_start_main+0xf0)[0x7fec7b9af790]
./subsurface(_start+0x29)[0x4dfda9]
======= Memory map: ========
00400000-00840000 r-xp 00000000 fd:02 1709596
/home/rick/localsrc/subsurface/build/subsurface
00a40000-00a54000 r--p 00440000 fd:02 1709596
/home/rick/localsrc/subsurface/build/subsurface
00a54000-00a5b000 rw-p 00454000 fd:02 1709596
/home/rick/localsrc/subsurface/build/subsurface
00a5b000-00a5f000 rw-p 00000000 00:00 0
023fe000-0686c000 rw-p 00000000 00:00 0
[heap]
7febe8000000-7febe8256000 rw-p 00000000 00:00 0
7febe8256000-7febec000000 ---p 00000000 00:00 0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150712/3ba69202/attachment-0001.html>