GSoC Status - Week 7 (Customizable prints)

[Gehad Elrobey]

On Tue, Jul 14, 2015 at 1:29 PM, Lubomir I. Ivanov <neolit123 at gmail.com>
wrote:

> On 14 July 2015 at 13:19, Gehad Elrobey <gehadelrobey at gmail.com> wrote:
> >
> > On Jul 14, 2015 12:15 PM, "Lubomir I. Ivanov" <neolit123 at gmail.com>
> wrote:
> >>
> >> On 14 July 2015 at 00:16, Gehad Elrobey <gehadelrobey at gmail.com> wrote:
> >> >
> >> > Should I convert the dive profile to QImage during previewing only or
> >> > should
> >> > I convert it during actual printing also which will affect the
> printing
> >> > quality?
> >> >
> >>
> >> i can't build ATM, but i think the logic here is a bit wrong:
> >>
> >>
> https://github.com/Gehadelrobey/subsurface/commit/d5b9e8424f82f4960d44a2f16abda1cbf27d7673
> >>
> >> "We must pass a QPaintDevice with type QPixmap for previewing and with
> >> type QPrinter for actual printing."
> >>
> >> does that include QPrintPreviewDialog as well? if so that's wrong.
> >> you can use a QPixmap if you are rendering an image to be shown in the
> >> template edit dialog, but the actual QPrintPreviewDialog contents
> >> should be pretty much the same as the printed contents (on a hardcopy
> >> or in a PDF).
> >>
> >
> > No, the preview function is used for the QPixmap in the TemplateEdit
> only,
> > while the QPrintPreviewDialog uses the actual print() function.
>
> both the preview and print profiles are in vector for me, which is good.
> also the color and edit seems to be working and the preferred colors
> are stored (in the settings/registry(win32), apparently).
>
> we *might* have to get some user feedback on the colors...i think
> storing them globally is a bad idea.
> will create a thread on the ML for that.
>
> 1) the "per-template" vs "global colors" issue..


Sorry, what do you mean by global colors? do you mean the almond_colors
instance of the color struct?


> .
> 2) "print in color" doesn't work - always prints in color; i guess you
> haven't finished the correct "to-greyscale" conversation yet, as we
> were discussing it just yesterday
>

Yes, "Print in color" works well in the printing mode only and not in
the QPrintPreviewDialog, as I didn't implement what we have discussed
yesterday yet.


> 3) i get no text / data in the tables under the profiles. could this
> be a bug on my end?
>
>
I am not sure why this happens, it works correctly for me, can you send me
the dive you are trying to print?

-- 
regards,

Gehad
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150714/c1bb6a4a/attachment.html>