[PATCH] Bluetooth improvements

Claudiu Olteanu olteanu.vasilica.claudiu at gmail.com
Sun Jul 19 12:23:46 PDT 2015


>
> Claudiu, most people only have one local bluetooth device. We shouldn't
> display a list to select an entry if there's only one entry to be selected.
> Can you hide the list if the list contains only one?
>

Of course I can do. One of the attached patches (#0009) should do the trick.


> Where is this deleted? Does QBluetoothLocalDevice take ownership?
>

This information should remain until the widget is destroyed. I thought
that it will be automatically deleted when I delete the *ui *instance.
Should I
manually clean his children?


> All of those QString() should be tr() so they cna be translated. I haven't
> checked previous patches for this...
>

None of the patches uses tr() . I will create a patch in the end which will
do the
translations.


> > +#elif defined(Q_OS_ANDROID) || (QT_VERSION >= 0x050500 &&
> > (defined(Q_OS_IOS) || defined(Q_OS_OSX)))
>
> Hint: Q_OS_DARWIN and Q_OS_MAC also mean Q_OS_IOS || Q_OS_OSX.
>

I saw that Q_OS_MAC doesn't include the open source version and I didn't
know which is that :).

Thanks for the hints,
Claudiu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150719/8cd54073/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-Update-the-message-shown-on-pairing-erorrs.patch
Type: text/x-patch
Size: 1384 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150719/8cd54073/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Hide-the-local-BT-combobox-if-there-is-only-one-devi.patch
Type: text/x-patch
Size: 2622 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150719/8cd54073/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Fix-typos-on-Bluetooth-selection-widget.patch
Type: text/x-patch
Size: 3243 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150719/8cd54073/attachment-0002.bin>


More information about the subsurface mailing list