[PATCH] Bluetooth improvements

Dirk Hohndel dirk at hohndel.org
Mon Jul 20 05:48:11 PDT 2015


On Sun, Jul 19, 2015 at 11:25:17PM +0300, Claudiu Olteanu wrote:
> >
> > Child QObjects don't need to be cleaned. But I'm not seeing any
> > parent-child
> > relationship here.
> >
> > I'm deferring to you here. I'm just pointing out, I haven't done any
> > investigation.
> >
> > Would you like me to?
> 
> I don't have too much experience with C++ and Qt framework. If you
> have time, it would be safer if do some investigation?

In general the mentor is not necessarily the clean up person...
I know, Thiago offered, but just to put this out here.

I will admit that I put somewhat less focus on making sure that we are
"leak free" than on some other cleanup tasks.

> > > I saw that Q_OS_MAC doesn't include the open source version and I didn't
> > > know which is that :).
> >
> > Huh?
> 
> I didn't look over the implementation. I just read the description from
> here[1] and it is
> mentioned something about an open source version :).
> 
> [1] - http://doc.qt.io/qt-5.5/qtglobal.html#Q_OS_MAC

Fun. But of course Thiago already clarified. I'll update the commit to be
consistent with what we use elsewhere (not that we are all that consistent
about these to be honest).

/D


More information about the subsurface mailing list