[PULL REQUEST] GSoC Printing: initial batch of patches
Dirk Hohndel
dirk at hohndel.org
Thu Jun 4 10:20:30 PDT 2015
On Thu, Jun 04, 2015 at 10:02:28AM -0700, Dirk Hohndel wrote:
> On Thu, Jun 04, 2015 at 05:58:10PM +0300, Lubomir I. Ivanov wrote:
> > So this is the initial work from Gehad. I'm looking forward to getting this in
> > master as he needs to continute the work into the template specific logic.
> > Rebasing all the time while waiting on me for reviews must be a pain, so this
> > is pending.
>
> OK, I added a few comments, some are arguably cosmetic, some are about
> hardcoding things. None should prevent me from pulling this in order to
> make your life easier.
>
> But please make it a high priority to address the comments I made on
> github.
>
> I will however turn this code off by default until we figured out the
> building of Grantlee
And of course this immediately showed that you didn't test compile this
with NO_PRINTING set ON :-/
This is now pushed, including a commit that fixes building with
NO_PRINTING=ON (which is currently the default)
/D
More information about the subsurface
mailing list