[PULL REQUEST] GSoC Printing: initial batch of patches

[Lubomir I. Ivanov]

On 4 June 2015 at 21:39, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Thu, Jun 04, 2015 at 09:13:34PM +0300, Lubomir I. Ivanov wrote:
>> replies:
>>
>> https://github.com/torvalds/subsurface/commit/3f3937f908b5c0044aef1caa196511469103daa7#commitcomment-11525543
>> > Why is this hard coded to A4? This should simply use the printer's default page size
>>
>> intentional. i did not object about these hardcoded values for testing purposes.
>> *any* size should be supported in the final implementation, otherwise
>> it would be incomplete.
>
> I'd still prefer that we don't have these constants all over the code but
> instead have a struct / class that holds the values. For now this can be
> initialized with the A4 values and then later it can be modified to
> support whatever size is needed.

yeah, one of the next steps should be to address the "any size" issue
and remove the constants.

>
>> >> As discussed this does break the current printing module in the expense of
>> >> not maintaining a couple of modules (old vs new) durring GSoC.
>> >> For users that follow master and don't want to install Grantlee please use
>> >> "cmake -DNO_PRINTING" but mind that Grantlee will be a hard dependency if you
>> >> ever want to print with Subsurface.
>> >
>> > Nope, for now we'll do it the other way around. You'll need to add
>> > -DNO_PRINTING=OFF in order to enable this in master
>>
>> should Gehad modify the cmake file so that NO_PRINTING is ON by default?
>
> I modified the commit and pushed all this already :-)
>
> So no, please sync to latest master and develop on top of that.
>

ok, understood.

lubomir
--