Dive Site Duplicates [was Re: Dive site management on daily build 4.4.2.669]

[Davide DB]

On Wed, Jun 10, 2015 at 8:17 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Wed, Jun 10, 2015 at 07:25:38PM +0200, Joakim Bygdell wrote:
>>
>> > On 10 Jun 2015, at 17:46, Dirk Hohndel <dirk at hohndel.org> wrote:
>> >
>> > But what if this is for example a wreck site and the user carefully
>> > specifies the exact GPS coordinates for the different entry points?
>> > But then, I guess, they'll have different names.
>>
>> Most likely yes.

Yes

>
> So what I'm looking to implement now would be something like this:
> (and remember, this is all for now about automatic creation of dive sites
> when importing from a V2 XML file)
>
> IF two sites have the same name
> AND they are closer than 20m
> THEN merge them into one site
>
> Different name or different GPS? Different sites.

Yes

>
> And of course next we need the ability to identify two sites and say "yep,
> these are the same, make them one" in the dive site management menu.
>

Yes


> I don't think we'll be able to come up with an algorithm that gets this
> perfectly right for every user. So I'm trying to come up with something
> that gets it right in most cases but doesn't prevent someone from fixing
> it later.
>
> So my rationale is "if you meant it to be two different dives, then you
> almost certainly should have given it different names". But I'll still
> keep the 20m threshold "just in case".

Once some "merge" or "find duplicates" tool will be available in the
dive sites management view, it would be nice having the threshold
configurable.

The above logic should be explained in the user manual. Especially how
to be sure to do not loose valuabel GPS point during the import.

About my points.
These are really strange. Currently Subsurface merges only the last
two that have exactly the same coords.
I had the companion app turned on the whole day and the rubber boat
was anchored all the time. Maybe my old smartphone gps was not
reliable.
I will merge these manually.

<location gps='42.363000 11.184300'>Porto Ercole - Punta Finestra</location>
<location gps='42.363100 11.184100'>Porto Ercole - Punta Finestra</location>
<location gps='42.363000 11.184400'>Porto Ercole - Punta Finestra</location>
<location gps='42.363100 11.184500'>Porto Ercole - Punta Finestra</location>
<location gps='42.363100 11.184200'>Porto Ercole - Punta Finestra</location>
<location gps='42.363200 11.185100'>Porto Ercole - Punta Finestra</location>
<location gps='42.363200 11.184100'>Porto Ercole - Punta Finestra</location>
<location gps='42.363200 11.184100'>Porto Ercole - Punta Finestra</location>

When I dive with a rubber boat I start the companion app in advance so
I don't know if I will go on a known spot.
I will merge these one regardless of the gps point. They are exactly
the same on different date.

<location gps='42.251600 11.116300'>Isola di Giannutri - Punta San
Francesco</location>
<location gps='42.251700 11.116500'>Isola di Giannutri - Punta San
Francesco</location>
<location gps='42.251600 11.116300'>Isola di Giannutri - Punta San
Francesco</location>
<location gps='42.251600 11.116300'>Isola di Giannutri - Punta San
Francesco</location>



-- 
Davide
https://vimeo.com/bocio/videos