[PATCH 2/3] Make the expand/collapse buttons usefull on trips

Anton Lundin glance at acc.umu.se
Wed Jun 17 12:46:38 PDT 2015


There where some issues with trying to access non-existing dom elements
when clicking them when showing trips.

Instead of fixing that issue, this actually makes them do something
useful, expanding and collapsing the trips.

Signed-off-by: Anton Lundin <glance at acc.umu.se>
---
 theme/list_lib.js | 34 ++++++++++++++++++++++++----------
 1 file changed, 24 insertions(+), 10 deletions(-)

diff --git a/theme/list_lib.js b/theme/list_lib.js
index 17f5206..0459aad 100644
--- a/theme/list_lib.js
+++ b/theme/list_lib.js
@@ -134,11 +134,18 @@ function view_pagging(start, end)
 */
 function expandAll()
 {
-	for (var i = start; i < start + sizeofpage; i++) {
-		if (i >= itemsToShow.length)
-			break;
-		unexpand(document.getElementById(itemsToShow[i]));
-		items[itemsToShow[i]].expanded = false;
+	if (tripsShown) {
+		for (var i = 0 ; i < trips.length ; i++) {
+			if (trips[i].expanded === false)
+				expand_trip(i);
+		}
+	} else {
+		for (var i = start; i < start + sizeofpage; i++) {
+			if (i >= itemsToShow.length)
+				break;
+			unexpand(document.getElementById(itemsToShow[i]));
+			items[itemsToShow[i]].expanded = false;
+		}
 	}
 }
 
@@ -147,11 +154,18 @@ function expandAll()
 */
 function collapseAll()
 {
-	for (var i = start; i < start + sizeofpage; i++) {
-		if (i >= itemsToShow.length)
-			break;
-		expand(document.getElementById(itemsToShow[i]));
-		items[itemsToShow[i]].expanded = true;
+	if (tripsShown) {
+		for (var i = 0 ; i < trips.length ; i++) {
+			if (trips[i].expanded === true)
+				unexpand_trip(i);
+		}
+	} else {
+		for (var i = start; i < start + sizeofpage; i++) {
+			if (i >= itemsToShow.length)
+				break;
+			expand(document.getElementById(itemsToShow[i]));
+			items[itemsToShow[i]].expanded = true;
+		}
 	}
 }
 
-- 
2.1.4



More information about the subsurface mailing list