[Patch] Fix planner notes gas change output logic

[Robert Helling]

Rick,

> On 18.06.2015, at 16:51, Rick Walsh <rickmwalsh at gmail.com> wrote:
> 
> 
> The attached patch should do just that.  Please have a look.

Thanks a lot for this. Too bad I currently have virtually no time to look at this in any detail and due to a family wedding this weekend possibly not before Monday.

Still a few remarks:

1) Could you split your patch into 2-3 patches, one for the segment type, another one for the new logic? git add -p is very helpful in doing this (as I recently learned).

2) Don’t use the gamix.gas.permille members directly or you will run into problems since air is stored as 0%O2+0%2He. If you want to treat the special cases separately, you are likely doublicating code. Please always use the helper functions get_o2(&gasmix) and get_he(&gasmix) if you really want the content and to test if two gases are the same, there is gasmix_distance(&gasmix1, &gasmix2).

3) I must say, I am not really a fan of the 0min stops. But people might convince me. What I had intended to do is to change the plan() such that after doing a gas change, it always waits for a minute (and that minute might later be configurable by the user). I think this is realistic as doing a gas change with all checks while continuously ascending is just unrealistic.

4) We could have a checkbox to turn on and off the segment type symbols (as we have for duration and runtime). If you want to try that, simply copy the code for those options.

5) Just a personal preference, i would use ↗ <https://en.wikipedia.org/wiki/%E2%86%97>, ↘ <https://en.wikipedia.org/wiki/%E2%86%98>, → <https://en.wikipedia.org/wiki/%E2%86%92_(disambiguation)> for ascent, descent and stop and not distinguish between stop and constant depth planned segment.
Best
Robert



--
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150619/085d8e39/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150619/085d8e39/attachment-0001.sig>