[PULL REQUEST] GSoC Printing: part 2

[Lubomir I. Ivanov]

On 20 June 2015 at 06:42, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Sat, Jun 20, 2015 at 05:19:15AM +0200, Gehad Elrobey wrote:
>> On Fri, Jun 19, 2015 at 9:05 PM, Lubomir I. Ivanov <neolit123 at gmail.com>
>> wrote:
>>
>> > So this is the second batch of patches for this GSoC task.
>> >
>> > Here Gehad has added another template which is the "one dive per page",
>> > some
>> > minor fixes and renames here and there and also support for printing on any
>> > page size (or "render target" size).
>> >
>> > Also good news is that I'm now actually able to use Grantlee properly
>> > on Windows and the printouts are rendered. Also the NO_PRINTING option
>> > actually
>> > works this time.
>
> I've been trying to get this to work here and can't. Clicking Preview gets
> me nothing (which you know - but it should at least give you a "not
> implemented, yet" or something.... Clicking print gets me an error that
> the template wasn't found.

"Preview" is a NOP, for now. i just said to Gehad to bring this back
from my previous implementation.
it was quite easy to accomplish using QPrintPreviewDialog and i've
missed why it was removed.

>> > - Not sure we have discussed a "Statistics print" for GSoC. Is this
>> > something
>> > which came from user requests - e.g. from IRC?
>> >
>> That was mentioned in the proposal, we can cancel this feature if you would
>> suggest this.
>
> I think there are lots of people who are interested in statistics - we
> need to redo them in the UI - but I'm not convinced that printing out
> statistics is all that interesting. Sure, it would be nice to have a
> summary at the end... n dives printed, max depth, total time spent...
>
> But beyond that it gets very hard to find statistics that are interesting
> for all the users. So I'd be OK with this being handled as "optional" and
> more focus being spent on getting things right.
>

i suggested that we move this into the nice-to-have zone of the
timeline near the end of the project.
i can also see the potential to add this later on even after GSoC is
over, if Gehad is interested that is.

for now, it would be best to hide the radio group options that are WIP
or just planned.

lubomir
--