[PATCH] Planner notes - revise logic for gasmix output

[Rick Walsh]

Thanks Robert,

I'm on my phone so I've read but haven't tested your patches.

On 23 Jun 2015 7:09 am, "Robert C. Helling" <helling at atdotde.de> wrote:
>
> Hi Rick,
>
> I am currently looking at the patch and write down things I notice.
>
> The gas change looks good for our case of a switch at a depth without a
stop (even when mandatory stop time is set to 0). But when I turn on
displayed transitions I would expect the gas change to be shown on the stop
rather than on the upwards transition that leads to it (as the later is
only the place to print it if there is no stop for it). I attached a patch
(to be applied on top of yours or for yours to be amended with it) to fix
that.
>

I deliberately didn't do that, but I prefer your logic, and the more I
think about it the more it makes sense.

>
>
> My compiler gives a warning that in that very long if statement there is
|| next to && and thus some parenthesis might add clarity. I would like to
chime in here and also suggest to break that condition over several more
lines essentially with one part of the || statement per line and to add
comments there so we will not be as confused again when we look at this in
a few months.
>
> Another stylistic thing: The bool gaschange is not a good name anymore
and should be renamed to something like gaschange_after and a similar
abbreviation gaschange_before could be introduced. Here is a second patch
for that:
>

Thanks for the feedback and code cleanup.  I've never done any c coding
before; I tried to be consistent with style but those changes make sense.

>
>
> But apart from that, this finally seems to do the right thing. Thanks a
lot for sorting this out!
>

Not a problem.  I'm only being selfish because I want to use the planner
and understand what it does.

> Best
> Robert
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150623/45d5ffc7/attachment.html>