[PATCH] Planner notes - revise logic for gasmix output

Dirk Hohndel dirk at hohndel.org
Tue Jun 23 06:16:05 PDT 2015


On Tue, Jun 23, 2015 at 11:10:17PM +1000, Rick Walsh wrote:
> Talking to myself....
> 
> On 23 June 2015 at 21:47, Rick Walsh <rickmwalsh at gmail.com> wrote:
> 
> >
> > I *think* the offending change is within the huge stack of conditional
> > statements in lines 644-680.  I believe I have got my head around it and
> > will send a patch tonight my time.
> >
> >
> The problem was that gaschange_after was set true at the first gaschange,
> then never got set false.  That messed with some logic.  I sent sent a very
> simple patch that fixes it.

That patch is awesome. I looked at it and said "but that's the same
condition!".
It really took me 5 seconds (and the commit message) to figure out why it
makes a huge difference.

Good catch, Rick!

/D


More information about the subsurface mailing list