great progress on dive site handling

[Dirk Hohndel]

On Sat, Jun 27, 2015 at 08:52:46AM +0200, Joakim Bygdell wrote:
> 
> > On 27 Jun 2015, at 5:53, Dirk Hohndel <dirk at hohndel.org> wrote:
> > 
> > Thanks to Tomaz for continuing to work on this.
> > 
> > The poor guy did two complete implementations that we ended up rejecting,
> > now he's started the third rewrite. And I think this one is promising.
> > Davide, this is not a departure from what you suggested but a small
> > addition - something that was doable in a limited amount of time and that
> > gives us back code that works - so it's now again possible to add and
> > modifiy dive sites.
> > 
> > This implementation allows you to type in the location box on the notes
> > panel. It will autocomplete to known sites and add a new site if an
> > unknown name is entered.
> > 
> > The edit button then opens a "quick edit popup" that is intended to
> > quickly edit / enter data. This is done as a popup to show that this is
> > just editing the site at which this dive happened.
> 
> On Mac the only way to get out of the pop-up window is to click on the top frame of the main window or switch to another application.
> Both on the daily and the one I build my self.

You should get out with ESC or just clicking in the Subsurface window. But
I admit that I haven't tried this on the Mac, yet. More to investigate.

> > I added code that I believe made the trip location edit work in a sane way
> > again (that had been broken for quite a while).
> 
> Seems to work, at least  the trip name is no longer saved as NULL.

Good. That had been annoying me quite a bit.

Thanks for testing.

/D